Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: sycl: convolution: implemented #1989

Merged
merged 1 commit into from
Jul 31, 2024
Merged

gpu: sycl: convolution: implemented #1989

merged 1 commit into from
Jul 31, 2024

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Jul 10, 2024

Implemented SYCL convolution, including FWD, BWD_DATA and BWD_WEIGHTS.

Also adds support for hardswish and sum zeropoints to post ops, as these are used in convolution tests.

@t4c1
Copy link
Contributor Author

t4c1 commented Jul 11, 2024

These test failures seem unconnected with the content of this PR.

@t4c1
Copy link
Contributor Author

t4c1 commented Jul 11, 2024

make test
enable device_gpu
enable thr_sycl
enable thr_cuda

mgouicem
mgouicem reviewed Jul 12, 2024
View reviewed changes
src/gpu/generic/sycl/ref_convolution.hpp Outdated Show resolved Hide resolved
src/gpu/generic/sycl/ref_convolution.hpp Outdated Show resolved Hide resolved
@t4c1 t4c1 requested a review from mgouicem July 18, 2024 10:42
@vpirogov vpirogov added this to the v3.6 milestone Jul 18, 2024
@vpirogov vpirogov added platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels Jul 18, 2024
kala855
kala855 reviewed Jul 19, 2024
View reviewed changes
src/gpu/gpu_convolution_list.cpp Outdated Show resolved Hide resolved
src/gpu/gpu_convolution_list.cpp Outdated Show resolved Hide resolved
src/gpu/gpu_convolution_list.cpp Outdated Show resolved Hide resolved
@t4c1
Copy link
Contributor Author

t4c1 commented Jul 25, 2024 •
edited

@mgouicem I think I addressed your comments and this PR has been sitting there for quite some time. When can I expect this to get merged?

@mgouicem
Copy link
Contributor

Thanks, LGTM. This will get merge on next pulldown.

@t4c1
Copy link
Contributor Author

t4c1 commented Jul 26, 2024

Thanks @mgouicem. By the way, how often do pulldowns happen?

@vpirogov vpirogov added platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic and removed platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels Jul 26, 2024
@vpirogov
Copy link
Member

Thanks @mgouicem. By the way, how often do pulldowns happen?

We currently do pulldowns every other week. Mid term plan is to move all development to public repository and allow key contributors promoting PRs directly.

@densamoilov densamoilov merged commit f9d70e0 into oneapi-src:main Jul 31, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kala855 kala855 kala855 approved these changes

@densamoilov densamoilov densamoilov approved these changes

@ShanoToni ShanoToni ShanoToni approved these changes

@mgouicem mgouicem mgouicem approved these changes

Assignees
No one assigned
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@t4c1 @mgouicem @vpirogov @kala855 @densamoilov @ShanoToni