cpu: aarch64: remove unnecessary workaround for f16 eltwise_tanh #1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a previously implemented workaround that falls back to the reference implementation of eltwise when the algorithm is tanh in f16. The original bug (ARM-software/ComputeLibrary#998) that the workaround addressed has been fixed.
Description
This patch removes a previously implemented workaround that falls back to the reference implementation of eltwise when the algorithm is tanh in f16. The original bug (ARM-software/ComputeLibrary#998) that the workaround addressed has been fixed.
Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?Performance improvements
The direct performance benefits are marginal (refer to attached verbose logs) but since the ACL implementation is used it allows oneDNN to benefit from future targeted optimisations.
Before:
After: