Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: workaround for MS STL breaking change #1958

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

vpirogov
Copy link
Member

@vpirogov vpirogov commented Jun 12, 2024

MSVC 19.40.33812.0 has a bug that results in incorrect optimizations and breaks all layer normalization tests.

@dzarukin dzarukin force-pushed the vpirogov/test-msvc-wa branch 2 times, most recently from 487d4b3 to 4ccc6d2 Compare June 18, 2024 00:00
@vpirogov
Copy link
Member Author

make test Lightweight_scans

@spalicki
Copy link
Contributor

make test Lightweight_scans

@spalicki spalicki requested a review from dzarukin July 18, 2024 03:42
@spalicki
Copy link
Contributor

make test
disable device_gpu

@vpirogov vpirogov added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Jul 18, 2024
@vpirogov vpirogov added this to the v3.6 milestone Jul 18, 2024
@spalicki
Copy link
Contributor

make test Lightweight_scans

@spalicki
Copy link
Contributor

make test
disable device_gpu

@vpirogov vpirogov merged commit cc041ec into main Jul 22, 2024
11 of 12 checks passed
@vpirogov vpirogov deleted the vpirogov/test-msvc-wa branch July 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants