Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for different src and dst datatypes in the SYCL implementation for pooling #1878

Merged
merged 1 commit into from
Jul 31, 2024
+12 −12
Merged

Add support for different src and dst datatypes in the SYCL implementation for pooling #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/gpu/generic/sycl/ref_pooling.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,17 @@ struct ref_pooling_fwd_t : public gpu::generic::sycl::primitive_t {

const bool ok = is_fwd() && set_default_params() == status::success
&& (src_md(0)->format_desc.blocking.inner_nblks == 0)
&& (utils::everyone_is(
s8, src_md(0)->data_type, dst_md(0)->data_type)
|| utils::everyone_is(u8, src_md(0)->data_type,
dst_md(0)->data_type)
|| utils::everyone_is(f32, src_md(0)->data_type,
dst_md(0)->data_type)
|| utils::everyone_is(bf16, src_md(0)->data_type,
dst_md(0)->data_type)
|| utils::everyone_is(f16, src_md(0)->data_type,
dst_md(0)->data_type)
|| utils::everyone_is(s32, src_md(0)->data_type,
dst_md(0)->data_type))
&& (!utils::one_of(
f64, src_md(0)->data_type, dst_md(0)->data_type))
&& (IMPLICATION(src_md(0)->data_type == bf16,
dst_md(0)->data_type == bf16))
&& (IMPLICATION(src_md(0)->data_type == s8,
dst_md(0)->data_type != u8))
&& (IMPLICATION(src_md(0)->data_type == u8,
dst_md(0)->data_type != s8))
&& (IMPLICATION(
src_md(0)->data_type != dst_md(0)->data_type,
desc()->prop_kind == forward_inference))
&& attr()->has_default_values(sm::post_ops)
&& attr_.set_default_formats(dst_md(0)) == status::success;
if (!ok) return status::unimplemented;
Expand Down
1 change: 1 addition & 0 deletions tests/benchdnn/pool/ref_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ void compute_ref_fwd(const prb_t *prb, const args_t &args) {
// XXX: this is a hack to let tests with padded area to pass for bf16
// dt due to the library initialize values with -max_dt, but not -INF.
float max_value = lowest_dt(prb->dst_dt());
if (is_nvidia_gpu()) max_value = lowest_dt(prb->src_dt());
float avg_value = 0.;
// Set initial value based on ws data type
int ws_off = prb->kernel_size() <= UINT8_MAX ? UINT8_MAX : INT_MAX;
Expand Down