-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU] [RISC-V] add compatible headers for new version of rvv intrinsics #1856
base: main
Are you sure you want to change the base?
[CPU] [RISC-V] add compatible headers for new version of rvv intrinsics #1856
Conversation
src/cpu/rv64/rvv_nchw_pooling.cpp
Outdated
@@ -17,7 +17,7 @@ | |||
|
|||
#include "rvv_nchw_pooling.hpp" | |||
#include <algorithm> | |||
#include <riscv_vector.h> | |||
#include "intrin_rvv.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "intrin_rvv.h" | |
#include "cpu/rv64/intrin_rvv.hpp" |
@@ -0,0 +1,16 @@ | |||
// Referenced from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright banner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply! Could you plz tell me how to resolve the copyright issues?
src/cpu/rv64/intrin_rvv.hpp
Outdated
#include "intrin_rvv_011_compat.h" | ||
#endif | ||
|
||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End-of-File symbol is missing.
The fact that this patch includes 30K LOCs of copy pasted code is a bit intimidating. I would suggest updating intrinsics in pooling implementation to RVV intrinsics v0.11 or even better stable RVV intrinsics v0.12. Compiler support is documented here. |
Thanks for your reply! I will try to update the intrinsics to the latest stable version! :) |
Description
I have been trying to cross-compile
openvino
for RISC-V target with rv64gcv arch recently, and I found an issue related to compatiblity of rvv intrinsics. See this issue for detailed information.Fixes the following github issue
openvinotoolkit/openvino#23784
Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?Performance improvements
New features
Bug fixes
RFC PR