-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sve capability check at runtime #2876
add sve capability check at runtime #2876
Conversation
This reverts commit 141d8e9. cpp/oneapi/dal/graph/undirected_adjacency_vector_graphqqq#
@napetrov @keeranroth have a look at this PR, this lays the base to push SVE tuned kernels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just thinking, if SVE is not supposed to be Arm specific, is it worth renaming the macro from TARGET_ARM
to TARGET_AARCH64
to show that it's the ISA that is being checked?
I think its better to keep arm, eventually when neon support is added it can be the default path. |
@@ -20,9 +20,11 @@ echo "Starting format check..." | |||
|
|||
RETURN_CODE=0 | |||
|
|||
CLANG_FORMAT_EXE=${CLANG_FORMAT_EXE:-clang-format-14} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to set specific version here as default? Because we generally do not update this file, the default clang-format option would be used which provides some flexibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I observed this issue since the current CI uses clang-format-14
, our systems had newer versions. The newer formatting was not compatible with clang-format-14
and hence failing the CI check. This allows to use the default version based on CI version.
/intelci: run |
Description
oneDAL is currently forced to use only SVE on arm platforms, with this new additional check it will validate the presence of SVE.
It checks for the SVE using hardware capabilities mentioned here - https://www.kernel.org/doc/html/v5.15/arm64/sve.html