Set means to zero in online covariance GPU if assume_centered=True #2850
+282
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegkkruglov
requested review from
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
Alexandr-Solovev
approved these changes
Jul 17, 2024
|
/intelci: run |
olegkkruglov
force-pushed
the
cov-online-assume-centered-fix
branch
from
61aaabf
to
2b6e141
Compare
|
/intelci: run |
|
|
||
| const te::dataframe input = | ||
| GENERATE_DATAFRAME(te::dataframe_builder{ 500, 40 }.fill_uniform(-100, 100, 7777), | ||
| te::dataframe_builder{ 1000, 20 }.fill_uniform(-30, 30, 7777), | ||
| te::dataframe_builder{ 10000, 100 }.fill_uniform(-30, 30, 7777), | ||
| te::dataframe_builder{ 100000, 20 }.fill_uniform(1, 10, 7777)); | ||
|
|
||
| INFO("num_rows=" << input.get_row_count()); |
There was a problem hiding this comment.
is it still necessary?
There was a problem hiding this comment.
do you mean the print? it allows to easier understand which dataset size failed in case of failure.
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description