-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workflows): add editorconfig-checker
#2849
Conversation
e86252a
to
b944ea7
Compare
# limitations under the License. | ||
#=============================================================================== | ||
|
||
VERSION=v3.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to set it as automatically updatable version? through automatic tool updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have updated renovate.json
config for this purpose: fe85bbe
Can we also add short readme on this check and how to run it? |
b944ea7
to
49d4fb1
Compare
Updated |
9b4be87
to
fe85bbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only comment is that we have many files in root dir of OneDAL and its a bit cluttered. Might be worth doing a little reorganization. Not in the scope of this PR but could look eventually.
Could you please clarify if you mean the presence of dotfiles in the root directory? It's common practice to keep these configuration files at the root level. |
should we integrate this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix broken link.
Description
This Pull Request adds an editorconfig-checker to CI pipeline.
Changes
ClangFormat
has been renamed toFormattersChecks
to better reflect the expanded scope of formatting checks.editorconfig-checker
has been added to the list of checks. This tool will verify that all submitted code follows the rules specified in.editorconfig
file..editorconfig
file has been added with the following configurations to maintain code quality and consistency across different file types including Python, Perl, C, C++, Java, and Fortran among others (max_line_length
temporary disabled):In case an error is found, the log will look like this:
![image](https://private-user-images.githubusercontent.com/35194825/349287281-5b00f904-9af7-4204-9ee0-a0a117dec7cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ4NjU2OTYsIm5iZiI6MTcyNDg2NTM5NiwicGF0aCI6Ii8zNTE5NDgyNS8zNDkyODcyODEtNWIwMGY5MDQtOWFmNy00MjA0LTllZTAtYTBhMTE3ZGVjN2NmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI4VDE3MTYzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0ZGRhZjJmMTUyMWM4MTcyMzZjYTk4OTk2ZTkyYTVmZDI0ZGI2ZjAyMjBkOGM0ZTc5ZDkzYWE5MmM3ZTRhZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CsVQPtfqk8N0W0xVQj2W-1EW8xUS8a3gzCHFhtmP72U)