-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate make to ICX/ICPX for Windows #2712
base: main
Are you sure you want to change the base?
Migrate make to ICX/ICPX for Windows #2712
Conversation
/intelci: run |
/intelci: run |
@Alexandr-Solovev |
/intelci: run |
/intelci: run |
1 similar comment
/intelci: run |
/intelci: run |
/intelci: run |
1 similar comment
/intelci: run |
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly just a question on when it makes sense to merge it. Would it make sense to validate on nightly scope? and would it make sense to check perf?
@ethanglaser Thanks for the review! I guess @napetrov knows better when we can merge it? I will launch nightly job + benchmarks and attach the links here: |
once ready i would say? |
/intelci: run |
/intelci: run |
/intelci: run |
@Alexsandruss any other comments, it doesn't affect scikit-learn-intelex due to it still uses icc/icl as default |
/intelci: run |
Description
In this pull request, we are migrating the project's default build system on Windows from the ICL to using ICX.
All changes are necessary to build oneDAL properly.
DAAL_EXPORT
was removed from some classes, due to correct dllexport build. In general just called functions should be marked as DAAL_EXPORT, and derived classes shouldn't. Most of the changes were done to have green CI.The concatenate operation
##
works pretty strange and MKL function macros have been updated for it.[[maybe_unused]]
is necessary for avoid compiler issues.The base version of C++ has been increased to C++17.