Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken link to oneccl spec #131

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bdmoore1
Copy link
Contributor

I fixed the link to the oneccl specification on the https://oneapi-src.github.io/oneCCL/programming-model.html page. This gh-pages PR is to update the public pages.

The sharepoint preview is not working right now, so if you want to see an output, download the zip below, extract all, and open the index page. Or just open the programming-model page, it's the one with the broken link.

https://intel-my.sharepoint.com/:u:/p/benjamin_d_moore/EfUzg6ZeiA5IvGE4ZSX2Xx8BG9lYXf8E19Oy3gTfF99yuA?e=NR5kFz

Copy link

@i-kosarev i-kosarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciekpac
Copy link
Contributor

I can see there are a lot of changes here. Is that because you made a general update of gh-pages ?

@bdmoore1
Copy link
Contributor Author

I can see there are a lot of changes here. Is that because you made a general update of gh-pages ?

Yes, whenever we build a new set of html files to capture changes in one file, github recognizes all files as having changed, even if there are no changes to the rest of the files.

@maciekpac
Copy link
Contributor

image

a lot of files were deleted, were that temporary files that had accidentally been published before ? There is no notion about that in the PR description

@bdmoore1
Copy link
Contributor Author

image

a lot of files were deleted, were that temporary files that had accidentally been published before ? There is no notion about that in the PR description

Yes, they are unnecessary files that were published in the past. Our tools team made a change to the script to stop producing those files. I forgot to mention that in the PR.

@nikitaxgusev nikitaxgusev merged commit 02f5947 into oneapi-src:gh-pages Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants