Upadte readme IntelPython_Numpy_Numba_dpex_kNN #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marina-Zubova
suggested changes
Jul 16, 2024
| @@ -2,13 +2,13 @@ | |||
|
|
|||
There was a problem hiding this comment.
In the sample title it's not very clear which numpy are we referring to - stock numpy or data parallel numpy. "Intel® Python NumPy" looks like Intel product, but there is no such product name
We need to think about how we can clarify the title. Maybe it could be "Intel® Python: NumPy vs numba-dpex Sample" or "NumPy vs numba-dpex Sample"
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| The necessary tools and components are already installed in the environment. You do not need to install additional components. See [Intel® DevCloud for oneAPI](https://devcloud.intel.com/oneapi/get_started/) for information. | ||
| ``` | ||
| pip install notebook |
There was a problem hiding this comment.
we need a requirements.txt file for this sample with ipykernel inside it. Alternatively, we can add ipykernel to the pip install command
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marina Zubova <122559084+Marina-Zubova@users.noreply.github.com>
Marina-Zubova
approved these changes
Jul 23, 2024
jimmytwei
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Update README.md file for IntelPython_Numpy_Numba_dpex_kNN code sample to reflect new AI README Template and explain how to install IDP using offline installer.
Type of change
Code sample maintenece
How Has This Been Tested?
N/A