-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upadte readme IntelPython_Numpy_Numba_dpex_kNN #2385
Upadte readme IntelPython_Numpy_Numba_dpex_kNN #2385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DX reviewed, left comments, suggested changes where relevant
@@ -2,13 +2,13 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the sample title it's not very clear which numpy are we referring to - stock numpy or data parallel numpy. "Intel® Python NumPy" looks like Intel product, but there is no such product name
We need to think about how we can clarify the title. Maybe it could be "Intel® Python: NumPy vs numba-dpex
Sample" or "NumPy vs numba-dpex
Sample"
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
|
||
The necessary tools and components are already installed in the environment. You do not need to install additional components. See [Intel® DevCloud for oneAPI](https://devcloud.intel.com/oneapi/get_started/) for information. | ||
``` | ||
pip install notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a requirements.txt file for this sample with ipykernel inside it. Alternatively, we can add ipykernel to the pip install command
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
AI-and-Analytics/Features-and-Functionality/IntelPython_Numpy_Numba_dpex_kNN/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marina Zubova <122559084+Marina-Zubova@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved by DX, thank you!
Existing Sample Changes
Description
Update README.md file for IntelPython_Numpy_Numba_dpex_kNN code sample to reflect new AI README Template and explain how to install IDP using offline installer.
Type of change
Code sample maintenece
How Has This Been Tested?
N/A