-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPGA: Add new sample SVD
#2320
base: development
Are you sure you want to change the base?
FPGA: Add new sample SVD
#2320
Conversation
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/non_std_covariance.hpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/print_matrix.hpp
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/svd_testbench_tool.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you get the chance to compute estimated performance to compare with what you obtained in HW?
*/ | ||
template <typename T> | ||
class GoldenPCA { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCA? I guess you meant SVD? Or maybe you didn't mean to add this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copy the golden PCA to obtain the eigen values for reference, so it technically is PCA
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/post_process.hpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/CMakeLists.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes to readme. design structure looks good to me. overall well-documented but a couple of holes need to be filled in for clarity.
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/CMakeLists.txt
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/assets/SVD.svg
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/post_process.hpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/svd/src/post_process.hpp
Outdated
Show resolved
Hide resolved
DirectProgramming/C++SYCL_FPGA/include/streaming_covariance_matrix.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme updates.
structure looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling mistakes
Description
Adding a new FPGA reference design Singular Value Decomposition.
Testing
Reg-test (Linux): https://spetc.intel.com/testanalysis?trview=0&testRunIds=10639364&tapgsize=20
Checklist
Administrative
Code Development
Security and Legal
Review