Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change loader log file location #157

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Change loader log file location #157

merged 1 commit into from
Jun 27, 2024

Conversation

Jemale
Copy link
Contributor

@Jemale Jemale commented Jun 17, 2024

No description provided.

lisanna-dettwyler
lisanna-dettwyler requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reversed, such that the log file is always called ze_loader.log but you can override where it gets put. I can work on this soon.

source/loader/ze_loader.cpp Outdated Show resolved Hide resolved
@Jemale
Copy link
Contributor Author

Jemale commented Jun 25, 2024

I think this should be reversed, such that the log file is always called ze_loader.log but you can override where it gets put. I can work on this soon.

I'm not sure I understand, if a user doesn't set ZEL_LOADER_LOG_FILE then the log file is #define LOADER_LOG_FILE_DEFAULT "ze_loader.log"

@lisanna-dettwyler
Copy link
Contributor

What I mean is, eliminate ZEL_LOADER_LOG_FILE and introduce ZEL_LOADER_LOG_DIR. If it's not set, default to ~/.oneapi_logs. Rename LOADER_LOG_FILE_DEFAULT to LOADER_LOG_FILE. Reasoning is that I just think it's more likely that someone would want to change where the logs get put (like if running in a system where ~ isn't used/writable) than what our specific log file name is.

lisanna-dettwyler
lisanna-dettwyler requested changes Jun 26, 2024
View reviewed changes
source/loader/ze_loader.cpp Show resolved Hide resolved
source/loader/ze_loader.cpp Show resolved Hide resolved
source/loader/ze_loader.cpp Outdated Show resolved Hide resolved
@Jemale
Change loader log file location
18ecfd1 
Also apply upstream patch to fix Windows directory creation

Resolves: VLCLJ-2205

Signed-off-by: Jemale Lockett <jemale.lockett@intel.com>
@Jemale Jemale marked this pull request as ready for review June 26, 2024 21:38
@Jemale
Copy link
Contributor Author

Jemale commented Jun 27, 2024

The default location was now being changed to the user home, e.g. C:\Users\jlockett.oneapi_logs. That was failing due to the same issue in the linked bug

@Jemale Jemale merged commit 07527e6 into oneapi-src:master Jun 27, 2024
21 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisanna-dettwyler lisanna-dettwyler lisanna-dettwyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jemale @lisanna-dettwyler