Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed goToDefinition command #42

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

zeevl
Copy link

@zeevl zeevl commented May 13, 2020

the goToDefinition command started failing for me.

Upon further investigation, I'm not sure why it was doing all the work it was doing, so I replaced it with a simple call to vscode.commands.executeCommand('editor.action.goToDeclaration');

@thomas-darling
Copy link

@felipenmoura This is probably one of the most used features, and it's been broken for a while now.
If this fix works, it would be really great to get it merged and released soon 🙂

@felipenmoura
Copy link
Contributor

Hi
Yup, I am having trouble loging into the extensions platform! We have some updates and even some PRs merged, but I can't publish it! I'm in touch with MS team and opened an issue. Fingers crossed to solve this asap!

@linonetwo
Copy link

linonetwo commented Aug 5, 2020

Is there anything we can help? @felipenmoura

This has been long waited for, maybe we can send mails to MS to support you?

@linonetwo
Copy link

@felipenmoura As you can login to Github, can you merge this PR first?

@felipenmoura felipenmoura merged commit 0ddc63e into on2-dev:master Aug 17, 2020
@Lewis2z
Copy link

Lewis2z commented Oct 1, 2020

@felipenmoura Thanks for fixing it on here. Is there any update on when the fix will be published?

@sammccants
Copy link

Yup, I am having trouble loging into the extensions platform! We have some updates and even some PRs merged, but I can't publish it! I'm in touch with MS team and opened an issue. Fingers crossed to solve this asap!

@felipenmoura has there been any progress with getting a new release out? I would love to have this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants