get_dataclass_data: branch on dataclass vs dataclass instance
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasha10
force-pushed
the
closes830
branch
2 times, most recently
from
e670dbb
to
f787425
Compare
Jasha10
changed the title
get_dataclass_data: branch on whether input is dataclass vs dataclass instanceget_dataclass_data: branch on dataclass vs dataclass instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
_utils.get_dataclasses_datafunction to fix two closely-related bugs, #830 and #831.Change introduced
get_dataclass_data(obj)now branches based on whether its input is a dataclass vs a dataclass instance. This closes #830.get_dataclass_datano-longer branches based on whether the attribute lookupgetattr(obj, fieldname)is equal to the missing string"???". This closes #831.