Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify spec details in KHR_audio and add property summary tables #2

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

aaronfranke
Copy link

@aaronfranke aaronfranke commented Jan 4, 2024

Syncing with omigroup/gltf-extensions#199

Several aspects of the spec were not clear before. Changes:

  • Add property summary tables for all properties.
  • Specify default values in the tables and the prose.
  • Add details on the cone angle, specify this is an angular diameter and not a radius (this matches Web Audio).
  • Add note that a max distance of 0 should be treated as an infinite max distance.
  • Remove limitation of max distance only being available on linear, allow it for all.
  • Update the cone diagram to be clearer.

@aaronfranke aaronfranke marked this pull request as draft January 4, 2024 23:31
@aaronfranke aaronfranke force-pushed the KHR_audio_tweaks branch 3 times, most recently from 8e5f534 to a863ee8 Compare January 5, 2024 16:58
@aaronfranke aaronfranke marked this pull request as ready for review January 18, 2024 23:28
Copy link

@antpb antpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've gone through this line by line as a group and independently. LGTM!

@antpb antpb merged commit 96d4dcb into omigroup:KHR_audio Jan 18, 2024
@aaronfranke aaronfranke deleted the KHR_audio_tweaks branch January 18, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants