Add QER gating parameters

api/pfcpsim.proto

@@ -15,6 +15,7 @@ message CreateSessionRequest {
   string ueAddressPool = 4;
   string sdfFilter = 5;
   int32 qfi = 6; // Should be uint8
+  bool gateStatus = 7;
 }
 
 message ModifySessionRequest {

internal/pfcpctl/commands/sessions.go

@@ -18,6 +18,7 @@ type commonArgs struct {
 	GnBAddress string `short:"g" long:"gnb-addr" description:"The (g/e)nodeB address"`
 	SDFfilter string `short:"s" long:"sdf-filter" description:"The SDF Filter to use"`
 	QFI uint8 `short:"q" long:"qfi" description:"The QFI value for QERs. Max value 64."`
+	GateStatus bool `short:"t" long:"gate-status" description:"If set, the QER gate status will be CLOSED"`
 }
 
 type sessionCreate struct {
@@ -66,6 +67,7 @@ func (s *sessionCreate) Execute(args []string) error {
 		UeAddressPool: s.Args.UePool,
 		SdfFilter:     s.Args.SDFfilter,
 		Qfi: int32(s.Args.QFI),
+		GateStatus: s.Args.GateStatus,
 	})
 
 	if err != nil {

internal/pfcpsim/server.go

@@ -125,7 +125,11 @@ func (P pfcpSimService) CreateSession(ctx context.Context, request *pb.CreateSes
 	}
 
 	var SDFFilter = ""
-	var qfi uint8 = 0
+	var qfi, gateStatus uint8 = 0, ieLib.GateStatusOpen
+
+	if request.GateStatus {
+		gateStatus = ieLib.GateStatusClosed
+	}
 
 	if request.Qfi != 0 {
 		qfi = uint8(request.Qfi)
@@ -218,6 +222,7 @@ func (P pfcpSimService) CreateSession(ctx context.Context, request *pb.CreateSes
 				WithQFI(qfi).
 				WithUplinkMBR(50000).
 				WithDownlinkMBR(30000).
+				WithGateStatus(gateStatus).
 				Build(),
 
 			// Downlink application QER
@@ -227,6 +232,7 @@ func (P pfcpSimService) CreateSession(ctx context.Context, request *pb.CreateSes
 				WithQFI(qfi).
 				WithUplinkMBR(50000).
 				WithDownlinkMBR(30000).
+				WithGateStatus(gateStatus).
 				Build(),
 		}
 

pkg/pfcpsim/session/qer_builder.go

@@ -6,15 +6,16 @@ package session
 import "github.com/wmnsk/go-pfcp/ie"
 
 type qerBuilder struct {
-	method   IEMethod
-	qerID    uint32
-	qfi      uint8
-	isMbrSet bool
-	ulMbr    uint64
-	dlMbr    uint64
-	isGbrSet bool
-	ulGbr    uint64
-	dlGbr    uint64
+	method     IEMethod
+	qerID      uint32
+	qfi        uint8
+	isMbrSet   bool
+	ulMbr      uint64
+	dlMbr      uint64
+	isGbrSet   bool
+	ulGbr      uint64
+	dlGbr      uint64
+	gateStatus uint8
 
 	isIDSet bool
 }
@@ -64,6 +65,12 @@ func (b *qerBuilder) WithDownlinkGBR(dlGbr uint64) *qerBuilder {
 	return b
 }
 
+func (b *qerBuilder) WithGateStatus(status uint8) *qerBuilder {
+	b.gateStatus = status
+
+	return b
+}
+
 func (b *qerBuilder) validate() {
 	if !b.isIDSet {
 		panic("Tried to build a QER without setting the QER ID")
@@ -83,11 +90,15 @@ func (b *qerBuilder) Build() *ie.IE {
 		createFunc = ie.NewUpdateQER
 	}
 
+	gate := ie.NewGateStatus(0, 0) //Open
+	if b.gateStatus == ie.GateStatusClosed {
+		gate = ie.NewGateStatus(1, 1)
+	}
+
 	qer := createFunc(
 		ie.NewQERID(b.qerID),
 		ie.NewQFI(b.qfi),
-		// FIXME: we don't support gating, always OPEN
-		ie.NewGateStatus(0, 0),
+		gate,
 	)
 
 	if b.isMbrSet {

pkg/pfcpsim/session/qer_builder_test.go

@@ -54,7 +54,20 @@ func TestQERBuilder(t *testing.T) {
 				ie.NewQFI(2),
 				ie.NewGateStatus(0, 0),
 			),
-			description: "Valid Create QER",
+			description: "Valid Create QER with gate open",
+		},
+		{
+			input: NewQERBuilder().
+				WithID(1).
+				WithMethod(Create).
+				WithQFI(2).
+				WithGateStatus(ie.GateStatusClosed),
+			expected: ie.NewCreateQER(
+				ie.NewQERID(1),
+				ie.NewQFI(2),
+				ie.NewGateStatus(1, 1),
+			),
+			description: "Valid Create QER with Gate closed",
 		},
 		{
 			input: NewQERBuilder().