Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for the info subcommand with plain style #32

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 20, 2019

See #31 (comment)

  • 49b8cad adds a new integration test covering the --style plain output of the info subcommand including some assertion that there is no printing error in the stderr
  • ff001f6 fixes the printing error

@dominikl
Copy link
Member

Looks good 👍
The 'print' error is gone and test passes.

Not a matter of this PR, but I was wondering what the hard coded rdefv1 in the plain output stands for. Should that not rather be the version of the rdef specification (like in the yaml output etc.)?

@sbesson
Copy link
Member Author

sbesson commented Nov 21, 2019

I think you are correct. The plain representation is probably now superseded by the more formal JSON/YAML output but f5f2ea1 updates code and test to reflect the value of SPEC_VERSION

@dominikl
Copy link
Member

Thanks. Looks like I missed the __str__ method when I added SPEC_VERSION variable.
I think it's good to merge 👍 But can also do another quick test tomorrow, when it's in the snoopy repo.

@sbesson
Copy link
Member Author

sbesson commented Nov 22, 2019

Happy to wait for a final sign-off before merging this.

@dominikl
Copy link
Member

Tested again today, looks fine 👍

@sbesson sbesson merged commit 5c9683b into ome:master Nov 22, 2019
@sbesson sbesson deleted the info_plain branch November 22, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants