Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #518

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Spelling #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4491615
spelling: automata
jsoref May 31, 2022
fb21c94
spelling: deterministic
jsoref May 31, 2022
cecfcd2
spelling: environments
jsoref May 31, 2022
7dad87d
spelling: lexemes
jsoref May 31, 2022
b1b27b3
spelling: original
jsoref May 31, 2022
838f9ae
spelling: pipeline
jsoref May 31, 2022
f6b582a
spelling: primitives
jsoref May 31, 2022
e18f2a7
spelling: separator
jsoref May 31, 2022
56cf8cb
spelling: unregistered
jsoref May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

## 2.3.8

* Fix bug [#422](https://github.com/olivernn/lunr.js/issues/422) where a pipline function that returned null was not skipping the token as described in the documentation. Thanks [Stephen Cleary](https://github.com/StephenCleary) and [Rob Hoelz](https://github.com/hoelzro) for reporting and investigating.
* Fix bug [#422](https://github.com/olivernn/lunr.js/issues/422) where a pipeline function that returned null was not skipping the token as described in the documentation. Thanks [Stephen Cleary](https://github.com/StephenCleary) and [Rob Hoelz](https://github.com/hoelzro) for reporting and investigating.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like changing changelogs. If that applies, it's trivial for me to drop this.


## 2.3.7

Expand Down Expand Up @@ -140,7 +140,7 @@
* Replace array-like string access with ES3 compatible `String.prototype.charAt` [#186](https://github.com/olivernn/lunr.js/pull/186), thanks [jkellerer](https://github.com/jkellerer).
* Move empty string filtering from `lunr.trimmer` to `lunr.Pipeline.prototype.run` so that empty tokens do not enter the index, regardless of the trimmer being used [#178](https://github.com/olivernn/lunr.js/issues/178), [#177](https://github.com/olivernn/lunr.js/issues/177) and [#174](https://github.com/olivernn/lunr.js/issues/174)
* Allow tokenization of arrays with null and non string elements [#172](https://github.com/olivernn/lunr.js/issues/172).
* Parameterize the seperator used by `lunr.tokenizer`, fixes [#102](https://github.com/olivernn/lunr.js/issues/102).
* Parameterize the separator used by `lunr.tokenizer`, fixes [#102](https://github.com/olivernn/lunr.js/issues/102).

## 0.5.12

Expand Down
2 changes: 1 addition & 1 deletion build/wrapper_end
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
} else if (typeof exports === 'object') {
/**
* Node. Does not work with strict CommonJS, but
* only CommonJS-like enviroments that support module.exports,
* only CommonJS-like environments that support module.exports,
* like Node.
*/
module.exports = factory()
Expand Down
2 changes: 1 addition & 1 deletion test/pipeline_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ suite('lunr.Pipeline', function () {
assert.equal(fn, pipeline._stack[0])
})

test('with unregisterd functions', function () {
test('with unregistered functions', function () {
var serializedPipeline = ['fn']

assert.throws(function () {
Expand Down
16 changes: 8 additions & 8 deletions test/query_lexer_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('foo bar')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably?

assert.lengthOf(this.lexer.lexemes, 2)
})

Expand Down Expand Up @@ -152,7 +152,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('+foo +bar')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 4)
})

Expand Down Expand Up @@ -216,7 +216,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('foo bar')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 2)
})

Expand Down Expand Up @@ -248,7 +248,7 @@ suite('lunr.QueryLexer', function () {
})
})

suite('hyphen (-) considered a seperator', function () {
suite('hyphen (-) considered a separator', function () {
setup(function () {
this.lexer = lex('foo-bar')
})
Expand All @@ -263,7 +263,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('title:foo')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 2)
})

Expand Down Expand Up @@ -453,7 +453,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('foo~2')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 2)
})

Expand Down Expand Up @@ -490,7 +490,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('foo^10')
})

test('produces 2 lexems', function () {
test('produces 2 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 2)
})

Expand Down Expand Up @@ -527,7 +527,7 @@ suite('lunr.QueryLexer', function () {
this.lexer = lex('title:foo^10~5')
})

test('produces 4 lexems', function () {
test('produces 4 lexemes', function () {
assert.lengthOf(this.lexer.lexemes, 4)
})

Expand Down
4 changes: 2 additions & 2 deletions test/token_set_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ suite('lunr.TokenSet', function () {

// a state reached by a wildcard has
// an edge with a wildcard to itself.
// the resulting automota is
// non-determenistic
// the resulting automata is
// non-deterministic
Comment on lines -61 to +62
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably?

assert.equal(wild, wild.edges['*'])
assert.isOk(wild.final)
})
Expand Down
4 changes: 2 additions & 2 deletions test/utils_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ suite('lunr.utils', function () {
})
})

suite('object with primatives', function () {
suite('object with primitives', function () {
subject({
number: 1,
string: 'foo',
Expand Down Expand Up @@ -54,7 +54,7 @@ suite('lunr.utils', function () {
assert.deepEqual(this.obj.array, this.clone.array)
})

test('mutations on clone do not affect orginial', function () {
test('mutations on clone do not affect original', function () {
this.clone.array.push(4)
assert.notDeepEqual(this.obj.array, this.clone.array)
assert.equal(this.obj.array.length, 3)
Expand Down