bump serde dependency to 1.0.107 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as older versions can't compile cargo_metadata because of serde-rs/serde#1804
|
Thanks! |
linabutler
added a commit
to mozilla/uniffi-rs
that referenced
this pull request
Aug 25, 2020
When building in Gecko, `cargo_metadata` panics in a macro. This is fixed in oli-obk/cargo_metadata#123 (and in Serde upstream), but pulling `uniffi` in as a path dependency in Gecko, and depending on `cargo_metadata` as a Git dependency, confuses Cargo. It doesn't update the vendored versions of Serde or other dependencies, then fails to build complaining it can't satisfy the newer versions that `uniffi` requests. In the interest of getting a demo working, I've just commented out the dependencies for now, and downgraded the other versions to match what's already vendored in m-c.
linabutler
added a commit
to mozilla/uniffi-rs
that referenced
this pull request
Aug 26, 2020
When building in Gecko, `cargo_metadata` panics in a macro. This is fixed in oli-obk/cargo_metadata#123 (and in Serde upstream), but pulling `uniffi` in as a path dependency in Gecko, and depending on `cargo_metadata` as a Git dependency, confuses Cargo. It doesn't update the vendored versions of Serde or other dependencies, then fails to build complaining it can't satisfy the newer versions that `uniffi` requests. In the interest of getting a demo working, I've just commented out the dependencies for now, and downgraded the other versions to match what's already vendored in m-c.
linabutler
added a commit
to mozilla/uniffi-rs
that referenced
this pull request
Aug 27, 2020
When building in Gecko, `cargo_metadata` panics in a macro. This is fixed in oli-obk/cargo_metadata#123 (and in Serde upstream), but pulling `uniffi` in as a path dependency in Gecko, and depending on `cargo_metadata` as a Git dependency, confuses Cargo. It doesn't update the vendored versions of Serde or other dependencies, then fails to build complaining it can't satisfy the newer versions that `uniffi` requests. In the interest of getting a demo working, I've just commented out the dependencies for now, and downgraded the other versions to match what's already vendored in m-c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as older versions can't compile cargo_metadata because of serde-rs/serde#1804