Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authstate issue during token renew OKTA-410934 #873

Closed

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Jul 21, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #873 (9704f52) into 5.2 (e5087b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.2     #873   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         116      116           
  Lines        3330     3331    +1     
  Branches      692      693    +1     
=======================================
+ Hits         3045     3046    +1     
  Misses        285      285           
Impacted Files Coverage Δ
lib/TokenManager.ts 94.53% <ø> (ø)
lib/AuthStateManager.ts 93.54% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5087b8...9704f52. Read the comment docs.

…during active token auto renew by only checking existence of both tokens from storage
@shuowu-okta shuowu-okta force-pushed the sw-fix-authstate-issue-during-token-renew-OKTA-410934 branch from 4d9be8f to 5ca8f26 Compare July 22, 2021 19:20
@shuowu shuowu mentioned this pull request Jul 22, 2021
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Jul 22, 2021
…during active token auto renew by only checking existence of both tokens from storage

OKTA-410934
<<<Jenkins Check-In of Tested SHA: b1a08a1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 9
PR Link: "#873"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants