Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ag okta 408017 fix renew token #845

Closed
wants to merge 2 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

refresh token was attempted to be "renewed":

  • "expiresAt" was placed on refresh token (but this value belongs to access token)
  • refresh token would "renew" right after accessToken (since they had same expiresAt)

adds logic to setExpireEventTimeout to skip refresh tokens - the refresh token is returned when renewing the access token or id token.

@aarongranick-okta aarongranick-okta changed the base branch from master to 5.2 June 29, 2021 00:22
Copy link
Contributor

@shuowu shuowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@codecov-commenter
Copy link

Codecov Report

Merging #845 (5b93780) into 5.2 (386ae2c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.2     #845   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         116      116           
  Lines        3333     3333           
  Branches      691      691           
=======================================
  Hits         3045     3045           
  Misses        288      288           
Impacted Files Coverage Δ
lib/oidc/handleOAuthResponse.ts 100.00% <ø> (ø)
lib/TokenManager.ts 94.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386ae2c...5b93780. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants