Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(idx): canRemediate for options field in GenericRemediator #1207

Closed
wants to merge 2 commits into from
Closed

fix(idx): canRemediate for options field in GenericRemediator #1207

wants to merge 2 commits into from

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented May 8, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022 •
edited
Loading

Codecov Report

Merging #1207 (dd64627) into 6.5 (5a43bdb) will increase coverage by 0.00%.
The diff coverage is 94.11%.

@@           Coverage Diff           @@
##              6.5    #1207   +/-   ##
=======================================
  Coverage   93.41%   93.42%           
=======================================
  Files         157      157           
  Lines        4544     4565   +21     
  Branches     1045     1053    +8     
=======================================
+ Hits         4245     4265   +20     
- Misses        280      281    +1     
  Partials       19       19
Impacted Files Coverage Δ
lib/idx/remediators/GenericRemediator/util.ts 94.11% <90.90%> (-2.66%) ⬇️
lib/idx/util.ts 94.66% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a43bdb...dd64627. Read the comment docs.

eng-prod-CI-bot-okta pushed a commit that referenced this pull request May 9, 2022
@shuowu @eng-prod-CI-bot-okta
fix(idx): canRemediate for options field in GenericRemediator
ce122fe 
OKTA-496904
<<<Jenkins Check-In of Tested SHA: dd64627 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 5
PR Link: #1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredperreault-okta jaredperreault-okta jaredperreault-okta approved these changes

@aarongranick-okta aarongranick-okta Awaiting requested review from aarongranick-okta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuowu @codecov-commenter @jaredperreault-okta @eng-services-aperture-github-bot-okta