Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(idx): canRemediate nested object logic in GenericRemediator - OKTA-495228 #1200

Closed
wants to merge 2 commits into from
Closed

fix(idx): canRemediate nested object logic in GenericRemediator - OKTA-495228 #1200

wants to merge 2 commits into from

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented May 3, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #1200 (b76570d) into 6.5 (73bc0e0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b76570d differs from pull request most recent head e9941d0. Consider uploading reports for the commit e9941d0 to get more accurate results

@@            Coverage Diff             @@
##              6.5    #1200      +/-   ##
==========================================
+ Coverage   93.32%   93.36%   +0.03%     
==========================================
  Files         157      157              
  Lines        4542     4539       -3     
  Branches     1043     1040       -3     
==========================================
- Hits         4239     4238       -1     
+ Misses        284      282       -2     
  Partials       19       19
Impacted Files Coverage Δ
lib/idx/types/api.ts 100.00% <ø> (ø)
lib/idx/remediators/GenericRemediator/util.ts 96.77% <100.00%> (+5.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bc0e0...e9941d0. Read the comment docs.

eng-prod-CI-bot-okta pushed a commit that referenced this pull request May 3, 2022
@shuowu @eng-prod-CI-bot-okta
fix(idx): canRemediate nested object logic in GenericRemediator - OKT…
f2f983c 
…A-495228

OKTA-495228
<<<Jenkins Check-In of Tested SHA: e9941d0 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 4
PR Link: #1200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongranick-okta aarongranick-okta aarongranick-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuowu @codecov-commenter @aarongranick-okta @eng-prod-CI-bot-2-okta