feat: allow passing device context to interact call #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredperreault-okta
approved these changes
Feb 3, 2022
lib/idx/interact.ts
Outdated
| recoveryToken | ||
| recoveryToken, | ||
|
|
||
| // X-Device-Token header need to paire with `client_secret` |
aarongranick-okta
approved these changes
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 142 142
Lines 3912 3913 +1
Branches 815 816 +1
=======================================
+ Hits 3634 3635 +1
Misses 278 278
Continue to review full report at Codecov.
|
shuowu
commented
Feb 3, 2022
| @@ -18,6 +18,7 @@ const express = require('express'); | |||
| const session = require('express-session'); | |||
| const mustacheExpress = require('mustache-express'); | |||
| const path = require('path'); | |||
| require('express-async-errors'); | |||
There was a problem hiding this comment.
due to v6 change, idx errors is thrown directly now, add this middleware for error handling purpose
This reverts commit 6f57d4b.
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Feb 4, 2022
OKTA-452538 <<<Jenkins Check-In of Tested SHA: a8827b8 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 5 PR Link: "#1093"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.