Skip to content

Commit

Permalink
Fix: Access control for the S3 buckets
Browse files Browse the repository at this point in the history
- create ownership controls
- explicitly set the access to private

See hashicorp/terraform-provider-aws#28353
  • Loading branch information
offbyone committed Jun 3, 2024
1 parent d1be1e0 commit 1bf80be
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,17 @@ resource "aws_s3_bucket" "blog" {
tags = local.tags
}

resource "aws_s3_bucket_acl" "blog" {
resource "aws_s3_bucket_ownership_controls" "blog" {
bucket = aws_s3_bucket.blog.id
acl = "private"
rule {
object_ownership = "BucketOwnerPreferred"
}
}

resource "aws_s3_bucket_acl" "blog" {
depends_on = [aws_s3_bucket_ownership_controls.blog]
bucket = aws_s3_bucket.blog.id
acl = "private"
}

resource "aws_s3_bucket_website_configuration" "blog" {
Expand Down Expand Up @@ -176,9 +184,17 @@ resource "aws_s3_bucket" "wwwblog" {
tags = local.tags
}

resource "aws_s3_bucket_acl" "wwwblog" {
resource "aws_s3_bucket_ownership_controls" "wwwblog" {
bucket = aws_s3_bucket.wwwblog.id
acl = "private"
rule {
object_ownership = "BucketOwnerPreferred"
}
}

resource "aws_s3_bucket_acl" "wwwblog" {
depends_on = [aws_s3_bucket_ownership_controls.wwwblog]
bucket = aws_s3_bucket.wwwblog.id
acl = "private"
}

resource "aws_s3_bucket_server_side_encryption_configuration" "wwwblog" {
Expand Down

0 comments on commit 1bf80be

Please sign in to comment.