Create Address from a static str

[kpob]

Summary by CodeRabbit

• New Features

  • Introduced new address formats and creation logic.
  • Added error handling for address creation failures.

• Improvements

  • Enhanced address creation with a new method for hex-encoded strings.
  • Updated as_account_hash method to improve flexibility.

• Bug Fixes

  • Added comprehensive error handling for better reliability.

• Tests

  • Added a test to verify new address creation functionality.

[coderabbitai]

Walkthrough

The updates enhance the core/src/address.rs and core/src/utils.rs files by introducing new address formats, improved address creation logic, and associated error handling. Additionally, a new utility function for decoding hex strings into byte arrays is added. These changes aim to improve the robustness and flexibility of address handling in the codebase.

Changes

Files	Change Summaries
core/src/address.rs	Updated with new address formats, creation logic, error handling, and added tests.
core/src/utils.rs	Introduced decode_hex_32 function for hex string decoding and a helper function for hex values.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Address
    participant Utils

    User ->> Address: Create new Address with hex string
    Address ->> Utils: Call decode_hex_32 with hex string
    Utils -->> Address: Return 32-byte array or error
    Address -->> User: Return new Address object or error

    User ->> Address: Call as_account_hash
    Address -->> User: Return Option<&AccountHash>

Loading

Poem

In the code where bytes do play,
New addresses find their way.
Hex to bytes, a seamless flow,
Error-free, they come and go.
With tests to guide, and constants true,
A better path for all to view.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cdf5479 and 5630ed5.

Files selected for processing (2)

• core/src/address.rs (4 hunks)
• core/src/utils.rs (1 hunks)

Additional comments not posted (4)

core/src/utils.rs (2)

109-131: The implementation of decode_hex_32 looks robust and handles errors appropriately.

---

133-140: The hex_char_to_value function is well-implemented with comprehensive handling of all hexadecimal characters.

core/src/address.rs (2)

12-18: The constants for address lengths are clearly defined and match the expected formats.

---

242-254: The test test_casper_address_new is comprehensive, effectively verifying the functionality of the new method for both contract and account address types.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5630ed5 and 20f237d.

Files selected for processing (1)

• core/src/address.rs (5 hunks)

Files skipped from review as they are similar to previous changes (1)

• core/src/address.rs