Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item tooltip rework #3163

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

builder-247
Copy link
Member

@builder-247 builder-247 commented Mar 16, 2024

Overview

This PR is a rework of the item tooltip system, very closely matching the in-game panorama UI.
The old tooltip code was no longer working as intended, and it was also made before the in-game
tooltip rework.

Changes

  • Fixed number highlighting in ability tooltip description
  • Moved AbilityBehaviour to its own component which is shared by ItemTooltip
    • Added dispel information to AbilityBehaviour
    • Renamed spell immunity to debuff immunity
    • Updated colors for damage types
  • utility: added support for custom styles in styleValues
  • Reworked item tooltips
    • Now displays stats correctly
    • Added neutral item tier
    • Added ability behavior
    • Added health cost, fixed mana cost and cooldown
    • Added patchnotes from last two minor patches, closes Add patchnotes to item hovers #3141

Known issues

For backpacked items the cooldown & mana icons get resized incorrectly, haven't figured out how to fix this Fixed in #3164

Comparisons

image

image

image

Patchnotes:
image

@howardchung howardchung merged commit 533f741 into odota:master Mar 16, 2024
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add patchnotes to item hovers
2 participants