New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix universal hero base attack #3114

Merged

howardchung merged 1 commit into odota:master from ThePeregrinus:main

Sep 20, 2023

Contributor

ThePeregrinus commented Sep 20, 2023

Universal heroes have NaN base attack

It happens because primaryAttrValue retuns underfined if universal hero(there is no base_all property in heroes.json)

screenshot after fix


          fix universal hero base attack

e134773

howardchung approved these changes

View reviewed changes

howardchung merged commit 7c796c2 into odota:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet