Move from CRA to Vite #3103
Closed
Move from CRA to Vite #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbch
commented
Jun 15, 2023
|
|
||
| // blur whole heatmap | ||
| ctx.drawImage(heatmap.current, 0, 0); | ||
| // heatmap.setData(adjustedData); |
|
I've done a little research into converting CRA projects and it seems like Vite is an easier drop-in replacement for CRA, so if the Next.js effort is stalled it seems we could get some dev wins out of figuring out the blockers here |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS STILL WIP
This PR migrates the project from Create React App to Vite. Why?
https://semaphoreci.com/blog/vite
In general CRA is slower than Vite. Vite is pretty fast as it is using ESMby default skipping the whole bundling process for es modules.
From my tests everything looked okay. I guess secrets would need to be updates on the hosting part (as instead of using
REACT_APP_*for env vars Vite is falling back toVITE_)From my feeling Vite feels way faster and snappier on building & starting up the project, specially after the app was cached.
Important
One thing that didn't work anymore was the
heatmap.jspackage as it doesn't seem to support Vite. Looking at the activity of the package (https://github.com/pa7/heatmap.js) it seems to be quite dead.To fix this issue for now I built a very basic heatmap with canvas on my own. It's not as beautiful as heatmap.js heatmaps because of the missing color grading between points - but this could be built afterwards.
Otherwise the PR currently does not load the page since something is not working with Recharts. Looking at this tomorrow.