Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Aghs Tooltip on Hero Page #2753

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

skitttt
Copy link

@skitttt skitttt commented Apr 9, 2021

This change brings a new ability slot within the hero page to display the aghanims descriptions (shard and scepter). This data is pulled from dotaconstants using the generated aghs_desc.json file.

Currently does not work, problem with accessing data from aghs_desc.json object structure....because I have no idea what I'm doing. any help is appreciated!

@@ -38,7 +38,7 @@ const AbilityIcon = styled.img`
const AbilityManaComsumption = styled.div`
background: ${constants.colorBlackMuted};
color: ${constants.colorMana};
border-radius: 2px 0 0 0;
border-radius: 4px 0 4px 0;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed subtle problem with rounded corners of mana consumption icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant