Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up formatting, Enhanced SPA functionality. Enabled redux-dev-tools #1

Merged
merged 3 commits into from
May 27, 2016
Merged

Cleaned up formatting, Enhanced SPA functionality. Enabled redux-dev-tools #1

merged 3 commits into from
May 27, 2016

Conversation

gu3st
Copy link
Contributor

@gu3st gu3st commented May 27, 2016

Cleaned up some weird formatting. Added redux-dev-tools. Used Link component where appropriate to enable SPA navigation.


const NavBar = (props) => {
var navLeft, navRight
if(props.isFetching){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

own line

@mike-robertson
Copy link
Member

I added all these changes (except a few style changes which wouldn't make sense to spend time on with the file shift). I think if we can get to one codebase quickly, it will be better so we aren't going 2 separate directions with design. I can probably refactor the rest of the codebase to be more component-ized (see: https://facebook.github.io/react/docs/thinking-in-react.html) relatively quickly though.

@howardchung howardchung merged commit a339d3d into odota:gh-pages May 27, 2016
@gu3st gu3st deleted the cleanup-and-linkify branch May 28, 2016 00:08
@mike-robertson mike-robertson mentioned this pull request Sep 20, 2016
howardchung pushed a commit that referenced this pull request Aug 19, 2017
howardchung pushed a commit that referenced this pull request Sep 15, 2017
bdbch added a commit that referenced this pull request May 4, 2018
howardchung pushed a commit that referenced this pull request Jan 24, 2019
howardchung pushed a commit that referenced this pull request Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants