Skip to content

Commit

Permalink
add some more headings/labeling
Browse files Browse the repository at this point in the history
  • Loading branch information
howardchung committed Feb 16, 2017
1 parent 3d4665d commit c5b57b0
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/components/Player/Pages/Histograms/Histograms.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,18 @@ import React from 'react';
import { connect } from 'react-redux';
import { getPlayerHistogram } from 'actions';
import { playerHistogram } from 'reducers';
// import Heading from 'components/Heading';
import Heading from 'components/Heading';
import { HistogramGraph } from 'components/Visualizations';
import ButtonGarden from 'components/ButtonGarden';
import histogramNames from 'components/Player/Pages/matchDataColumns';
import { TableFilterForm } from 'components/Form';
import Container from 'components/Container';
import { browserHistory } from 'react-router';
import strings from 'lang';

const Histogram = ({ routeParams, columns, playerId, error, loading }) => (
<div style={{ fontSize: 10 }}>
<Heading title={strings.histograms_name} subtitle={strings.histograms_description} />
<TableFilterForm />
<ButtonGarden
onClick={buttonName => browserHistory.push(`/players/${playerId}/histograms/${buttonName}${window.location.search}`)}
Expand Down
3 changes: 2 additions & 1 deletion src/components/Player/Pages/Trends/Trends.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ import {
import { playerTrends } from 'reducers';
import ButtonGarden from 'components/ButtonGarden';
import trendNames from 'components/Player/Pages/matchDataColumns';
// import Heading from 'components/Heading';
import Heading from 'components/Heading';
import { TableFilterForm } from 'components/Form';
import Container from 'components/Container';
import { browserHistory } from 'react-router';
import strings from 'lang';

const Trend = ({ routeParams, columns, playerId, error, loading }) => (
<div style={{ fontSize: 10 }}>
<Heading title={strings.trends_name} subtitle={strings.trends_description} />
<TableFilterForm />
<ButtonGarden
onClick={buttonName => browserHistory.push(`/players/${playerId}/trends/${buttonName}${window.location.search}`)}
Expand Down
8 changes: 7 additions & 1 deletion src/lang/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@
"tab_wardmap": "Wardmap",
"tab_wordcloud": "Wordcloud",
"tab_mmr": "MMR",
"tab_rankings": "Rankings",
"tab_rankings": "Seasonal Rankings",
"tab_benchmarks": "Benchmarks",
"tab_performances": "Performances",
"tab_damage": "Damage",
Expand Down Expand Up @@ -687,6 +687,12 @@
"tooltip_estimated_mmr": "MMR estimate based on the mean visible MMR of the recent matches played by this user",
"tooltip_backpack": "Backpack",

"histograms_name": "Histograms",
"histograms_description": "Percentages indicate win rates for the labeled bin",

"trends_name": "Trends",
"trends_description": "Cumulative average over last 500 games",

"xp_reasons_0": "Other",
"xp_reasons_1": "Creep",
"xp_reasons_2": "Hero",
Expand Down

0 comments on commit c5b57b0

Please sign in to comment.