Add minRank and maxRank query parameters to /publicMatches

[ff137]

Adds minRank and maxRank query parameters and uses avg_rank_tier field in public_matches to filter results.

    "/publicMatches": {
      get: {
...
        parameters: [
          { $ref: "#/components/parameters/lessThanMatchIdParam" },
          { $ref: "#/components/parameters/minRankParam" },
          { $ref: "#/components/parameters/maxRankParam" },
          { $ref: "#/components/parameters/mmrAscendingParam" },
          { $ref: "#/components/parameters/mmrDescendingParam" },
        ],
...
        route: () => "/publicMatches",
        func: async (req, res, cb) => {
...
          if (req.query.mmr_ascending) {
            order = "ORDER BY avg_rank_tier ASC NULLS LAST";
          } else if (req.query.mmr_descending) {
            order = "ORDER BY avg_rank_tier DESC NULLS LAST";
          } else {
            order = "ORDER BY match_id DESC";
            moreThan = 0;
          }
          let minRank= req.query.min_rank
            ? `AND avg_rank_tier >= ${req.query.min_rank}`
            : "";
          let maxRank= req.query.max_rank
            ? `AND avg_rank_tier <= ${req.query.max_rank}`
            : "";

          db.raw(
            `
          WITH match_ids AS (SELECT match_id FROM public_matches
          WHERE TRUE
          AND match_id > ?
          AND match_id < ?
          ${minRank}
          ${maxRank}
          ${order}
          LIMIT 100)
          SELECT * FROM
...

[builder-247]

I'm pretty sure the mmr field isn't being updated anymore, average_rank should be used instead

[ff137]

I'm pretty sure the mmr field isn't being updated anymore, average_rank should be used instead

Oh, ok. I was just going off the response from: https://api.opendota.com/api/publicMatches

In that case, avg_mmr should probably be removed from the response? To avoid confusion. Or, avg_mmr should be implemented again? Is there a reason it's not being updated anymore?

[ff137]

@howardchung I notice the indenting in the spec description causes it to render like this:

Included a fix for that