Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unshare: use by default accountType User #771

Merged
merged 1 commit into from
Oct 16, 2016
Merged

Commits on Oct 16, 2016

  1. unshare: use by default accountType User

    Fixes #747.
    
    By default use accountType User, as is done with share,
    so that users can easily do things like
    ```shell
    $ drive unshare -emails somebody@gmail.com -id some_id
    ```
    instead of getting back a cryptic error
    ```shell
    no matches found!
    ```
    
    and the common assumptions will work without them
    having to know the entire setup of share and unshare.
    I too found this confusing and had to step back a little
    to figure out that previously the accountTypes were
    never set hence the loop that runs through each file
    never runs.
    
    This change also ensures that if errors were encountered entirely
    errors, without any successful shares/unshares, we won't give back
    the previously cryptic and not useful error of
    ```shell
    no matches found!
    ```
    odeke-em committed Oct 16, 2016
    Configuration menu
    Copy the full SHA
    88d72e5 View commit details
    Browse the repository at this point in the history