Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Ruby 3.3 as supported one. #1696

Merged
merged 1 commit into from
Jun 10, 2024
Merged

feat: Add Ruby 3.3 as supported one. #1696

merged 1 commit into from
Jun 10, 2024

Conversation

simi
Copy link
Contributor

@simi simi commented May 31, 2024

Add latest Ruby 3.3 to CI and README.md. Is it time to remove EOL Rubies as well and push major version? I can submit additional PR if welcomed.


Btw. any idea what's with logo in README.md and why https://octokit.github.io/octokit.rb/ is outdated?

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd
Copy link
Contributor

Btw. any idea what's with logo in README.md and why https://octokit.github.io/octokit.rb/ is outdated?

Hey @simi Thanks for the changes here ❤️

As far as the logo goes, it's referencing the docs site which is the old way that we referenced the Gundam Cat. It needs to be updated.

As far as the docs go, this is unfortunately another relic of the past. We haven't generated those docs using yard for about 5 years now. Given we are a small team that is moving toward Generative SDKs the meta needs of some of our older SDKs have simply been deprioritized so that we can focus our efforts on the future.

Please feel free to tackle the out of date docs problem if you'd like and we'd be glad to get it reviewed. I've created an up for grabs issue here if you are interested!

@nickfloyd nickfloyd added the Type: Feature New feature or request label Jun 10, 2024
@nickfloyd nickfloyd changed the title Add Ruby 3.3 as supported one. feat: Add Ruby 3.3 as supported one. Jun 10, 2024
@nickfloyd nickfloyd merged commit 59b49eb into octokit:main Jun 10, 2024
16 checks passed
@simi simi deleted the ruby-33 branch June 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants