Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcvars calls. Fix MSVC DLL build step echos #3603

Closed
wants to merge 1 commit into from

Conversation

iboB
Copy link
Contributor

@iboB iboB commented Nov 18, 2020

This is related to #3601

Note that the CI is expected to fail after this commit. The fix is in the aforementioned PR

Two CI steps weren't being run. Calling vcvarsall causes the CI step to immediately complete with a success ignoring subsequent commands.

The fix is to use call of a complete batch file (the steps are being exectuted as a batch file and the correct way to "source" batch from batch is to use call)

Another fix here is the cmd echo-s in the MSVC DLL build step. echo on cmd doesn't work the same way it does on bash. The single quotes are literally echoed back. So removing the quotes fixes echo to output valid C++

@iboB
Copy link
Contributor Author

iboB commented Nov 18, 2020

@ocornut
Copy link
Owner

ocornut commented Nov 18, 2020

Thanks a lot for investigating this!
It's not everyday we intentionally and happily merge a PR that breaks CI :P

@ocornut
Copy link
Owner

ocornut commented Nov 18, 2020

Merged jointly in fcc2b71, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants