Rename base test assertion methods for consistency (open-telemetry#2084)

* Rename base test assertion methods for consistency * Renamed assertion method * Updated contrib SHA * Updated contrib SHA
ocelotl · Aug 30, 2021 · b4ebef9 · b4ebef9
1 parent 04f74ee
commit b4ebef9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ env:
   # Otherwise, set variable to the commit of your branch on
   # opentelemetry-python-contrib which is compatible with these Core repo
   # changes.
-  CONTRIB_REPO_SHA: 3ad534cbba41c2b92618f5f03c4c92cee4a72df6
+  CONTRIB_REPO_SHA: 2a92e255f7595024242e45c0050c8f3de7140b6b
 
 jobs:
   build:

diff --git a/tests/util/src/opentelemetry/test/test_base.py b/tests/util/src/opentelemetry/test/test_base.py
@@ -24,6 +24,8 @@
 
 
 class TestBase(unittest.TestCase):
+    # pylint: disable=C0103
+
     @classmethod
     def setUpClass(cls):
         cls.original_tracer_provider = trace_api.get_tracer_provider()
@@ -44,11 +46,11 @@ def tearDownClass(cls):
     def setUp(self):
         self.memory_exporter.clear()
 
-    def check_span_instrumentation_info(self, span, module):
+    def assertEqualSpanInstrumentationInfo(self, span, module):
         self.assertEqual(span.instrumentation_info.name, module.__name__)
         self.assertEqual(span.instrumentation_info.version, module.__version__)
 
-    def assert_span_has_attributes(self, span, attributes):
+    def assertSpanHasAttributes(self, span, attributes):
         for key, val in attributes.items():
             self.assertIn(key, span.attributes)
             self.assertEqual(val, span.attributes[key])