refactor: introduce parameter object to functions in Suggestor.ts #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies a number of other functions higher up the call stack
…torParameters parameter
|
claremacrae
changed the title
claremacrae
added
type: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Description
Introduce
SuggestorParametersparameter object to many functions inSuggestor.ts.Motivation and Context
As a next step, I want to refactor
Suggestor.tsto reduce some repetition.How has this been tested?
Checklist
yarn run lint.Terms