add union types to schema

[fprasx]

• Add union to schema
• Update adapter

Fixes #36.

[obi1kenobi]

The schema is reasonable 👍

Make sure to both update the adapter and the index lookup optimizations, otherwise we might end up in a situation where index lookups fail to find unions that otherwise get returned when the optimization isn't used.

Lmk if you get stuck on anything or would like to chat about anything.

[fprasx]

Sounds good. I'm basically just grepping for union/struct and adding union.

[fprasx]

Ok, the meat of it is there.

I'm not too familiar with the codebase, do you know if there are any specific union-related tests I should add, off the top of your head?

[obi1kenobi]

do you know if there are any specific union-related tests I should add

I'd add a test crate with some unions, and then make sure:

• querying for all unions and their fields returns correct data
• querying for union importable paths returns correct data (even with re-exports)
• querying unions by importable path returns correct data (this will use the fast paths and use an index lookup optimization)

[fprasx]

Hmm, it actually seems less disruptive to just test union where struct/enum are getting tested in the crates that exist right now, for example:

querying for union importable paths returns correct data (even with re-exports)

can be tested in the importable_paths test crate, where it's tested for struct/enum

[obi1kenobi]

Let me know when this is ready for another review!

[obi1kenobi]

can be tested in the importable_paths test crate, where it's tested for struct/enum

btw, make sure to check out that test case, because I'm not sure it's testing quite what we might be assuming it's testing here

[fprasx]

You're right, I did some more digging into the test crates, and that one is testing something else. I've actually come to your original conclusion post-dig, which is that it's just simpler to have a crate for unions. Because structs and enums were there from the beginning, there are no specific tests for them, rather they're just used everywhere. Since unions are new their introduction might cause some bugs so they can get ~their own crate~.

I've gotta a pretty busy day today, so I might not be able to finish this up today, but I'll try to get it done by the weekend!

[obi1kenobi]

Sounds good! Thanks for setting expectations explicitly as well, it'll help me plan my own day as well.

[fprasx]

Ok, added a test crate. I think I've covered everything (importing, visibility, field info), but not sure.

[obi1kenobi]

Awesome, ship it! 🚀

[obi1kenobi]

I've used a bit of magic automation to port this PR to rustdoc-v27 and rustdoc-v26, and I'll release new versions for all three so that the next cargo update in cargo-semver-checks picks them up automatically.