-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require plaintext signature method #135
Conversation
…en and Travis CI default (v2.5.1) is probably broken too.
@thejamespinto LGTM, second pair of eyes? |
+1. Thank you @confiks! |
+1 to this; we're having the same issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but conflicts need to be resolved.
I'm not going to do this after more than four years. |
That's quite reasonable! New management is going to handle it still. ;) |
Nice 👍 Please keep in mind that this PR included a explicit version choice of rubygems |
Ah, but you removed |
For some reason the plaintext signature class is not
require
'd by default, and cannot be used without explicitly requiring it. This has historically been so, and the tests go out of their way to manually require the class: https://github.com/oauth-xx/oauth-ruby/blob/705ae93/test/units/test_net_http_client.rb#L28. I have no idea why this choice has been made.Last year in issue #76 some users bumped their head against this. This should either be documented, or the class should just be required.
This pull request adds the require statement and removes all the require statements from the tests.
I also modified travis.yml to use a specific rubygems version, because master is probably broken (rubygems/rubygems#1679) and it can break in the future. The Travis CI default (v2.5.1) unfortunately is broken as well (rubygems/rubygems#1223).