Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to psalm 5 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −2
Open

feat: bump to psalm 5 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public function getConfigTreeBuilder(): TreeBuilder

public function addScopesConfiguration(ArrayNodeDefinition $rootNode): self
{
/** @psalm-suppress UndefinedInterfaceMethod */
$rootNode
->fixXmlConfig('scope')
->children()
Expand All @@ -61,6 +62,7 @@ public function addScopesConfiguration(ArrayNodeDefinition $rootNode): self

public function addKeyChainsConfiguration(ArrayNodeDefinition $rootNode): self
{
/** @psalm-suppress UndefinedInterfaceMethod */
$rootNode
->fixXmlConfig('key_chain')
->children()
Expand All @@ -83,6 +85,7 @@ public function addKeyChainsConfiguration(ArrayNodeDefinition $rootNode): self

public function addPlatformsConfiguration(ArrayNodeDefinition $rootNode): self
{
/** @psalm-suppress UndefinedInterfaceMethod */
$rootNode
->fixXmlConfig('platform')
->children()
Expand All @@ -104,6 +107,7 @@ public function addPlatformsConfiguration(ArrayNodeDefinition $rootNode): self

public function addToolsConfiguration(ArrayNodeDefinition $rootNode): self
{
/** @psalm-suppress UndefinedInterfaceMethod */
$rootNode
->fixXmlConfig('tool')
->children()
Expand All @@ -126,6 +130,7 @@ public function addToolsConfiguration(ArrayNodeDefinition $rootNode): self

public function addRegistrationsConfiguration(ArrayNodeDefinition $rootNode): self
{
/** @psalm-suppress UndefinedInterfaceMethod */
$rootNode
->fixXmlConfig('registration')
->children()
Expand Down
1 change: 1 addition & 0 deletions Security/Exception/LtiToolMessageExceptionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public function handle(Throwable $exception, Request $request): Response
$message = urlencode($exception->getMessage());

if (null !== $launchPresentation && null !== $launchPresentation->getReturnUrl()) {
/** @psalm-suppress PossiblyNullArgument - getReturnUrl cannot be null here */
$redirectUrl = sprintf(
'%s%slti_msg=%s&lti_log=%s&lti_errormsg=%s&lti_errorlog=%s',
$launchPresentation->getReturnUrl(),
Expand Down
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"nyholm/psr7": "^1.8",
"oat-sa/lib-lti1p3-core": "^7.0",
"psr/log": "^1 || ^2 || ^3",
"symfony/console": "^5.4",
"symfony/framework-bundle": "^5.4",
"symfony/psr-http-message-bridge": "^2.0",
"symfony/security-bundle": "^5.4",
Expand All @@ -24,9 +25,9 @@
"nesbot/carbon": "^2.72",
"php-coveralls/php-coveralls": "^2.4",
"phpunit/phpunit": "~9",
"psalm/plugin-phpunit": "^0.15.1",
"psalm/plugin-phpunit": "^0.18.4",
"symfony/browser-kit": "^5.4",
"vimeo/psalm": "^4.6"
"vimeo/psalm": "^5.18"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 2 additions & 0 deletions psalm.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://getpsalm.org/schema/config"
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
findUnusedBaselineEntry="true"
findUnusedCode="false"
>
<projectFiles>
<directory name="Action"/>
Expand Down