Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde_cbor to 0.10 #1897

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Bump serde_cbor to 0.10 #1897

merged 1 commit into from
Jul 11, 2019

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 5, 2019

Fixes #1885

@kostko kostko force-pushed the kostko/feature/serde-cbor-0.10 branch 2 times, most recently from eb5c09f to 867c42e Compare July 7, 2019 19:17
@Yawning
Copy link
Contributor

Yawning commented Jul 8, 2019

This looks trivially correct, why was CI canceled?

@kostko
Copy link
Member Author

kostko commented Jul 8, 2019

It is actually not entirely correct, I need to fix some serialization issues (e.g., the key manager response parsing can now be simplified as go-friendly enum serialization is now the default).

@kostko
Copy link
Member Author

kostko commented Jul 8, 2019

Blocked by pyfisch/cbor#136.

@kostko kostko force-pushed the kostko/feature/serde-cbor-0.10 branch from 867c42e to 7ba2660 Compare July 8, 2019 09:16
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1897 into master will decrease coverage by <.01%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   54.75%   54.75%   -0.01%     
==========================================
  Files         228      228              
  Lines       21442    21437       -5     
==========================================
- Hits        11741    11737       -4     
+ Misses       8447     8445       -2     
- Partials     1254     1255       +1
Impacted Files Coverage Δ
go/storage/mkvs/urkel/node/node.go 55.3% <0%> (-0.43%) ⬇️
go/worker/keymanager/keymanager.go 22.09% <0%> (+0.58%) ⬆️
go/common/namespace.go 71.42% <100%> (ø) ⬆️
go/scheduler/tendermint/tendermint.go 57.14% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf20dc...f215f93. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1897   +/-   ##
======================================
  Coverage    54.5%   54.5%           
======================================
  Files         225     225           
  Lines       21316   21316           
======================================
  Hits        11619   11619           
  Misses       8451    8451           
  Partials     1246    1246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ad2b0...7ba2660. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/serde-cbor-0.10 branch from 7ba2660 to a4cae64 Compare July 8, 2019 09:18
@kostko kostko force-pushed the kostko/feature/serde-cbor-0.10 branch from a4cae64 to f215f93 Compare July 11, 2019 08:43
@kostko
Copy link
Member Author

kostko commented Jul 11, 2019

Fix released in 0.10.1.

@kostko kostko merged commit 5126425 into master Jul 11, 2019
@kostko kostko deleted the kostko/feature/serde-cbor-0.10 branch July 11, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump serde_cbor to 0.10
2 participants