-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving "disaster_recovery" & "ovirt_disk" (documentation & phrasings) #562
Improving "disaster_recovery" & "ovirt_disk" (documentation & phrasings) #562
Conversation
d899c44
to
6ccbd27
Compare
@barpavel Anything else missing? If not, then please move the PR to review ... |
Yes, there were few more things I wanted to add, the PR is not finished. |
6136443
to
ff379d0
Compare
Actually one of the reasons this PR started, was that I saw the following strange documentation, see https://docs.ansible.com/ansible/latest/collections/ovirt/ovirt/ovirt_disk_module.html
I mean pay attention to the text that requires |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
ff379d0
to
1476294
Compare
5d5ed77
to
64319a9
Compare
64319a9
to
0e937fd
Compare
Improving "disaster_recovery" role variables documentation table: 1. Minor (IDE-automatic) table reformatting to eliminate a few IDE warnings. 2. Adding backquotes around values to denote them "as code". Signed-off-by: Pavel Bar <pbar@redhat.com>
Improving "ovirt_disk" - documentation, code comments & messages: 1. Minor rephrasing. 2. Fixing typos. 3. Consistent upper-case usage. Signed-off-by: Pavel Bar <pbar@redhat.com>
1. Improve "ovirt_disk::id" description to specify that "alias" is also an option. This also makes the description to be consistent with the "ovirt_disk::name" description. 2. Fixing warnings: a. Redundant "ssl" import causing "Unused import statement 'import ssl'". b. Several "Local variable 'XYZ' value is not used". c. Several "Shadows name 'disk' from outer scope". Signed-off-by: Pavel Bar <pbar@redhat.com>
Signed-off-by: Pavel Bar <pbar@redhat.com>
0e937fd
to
9e59aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
A few small improvements in
disaster_recovery
&ovirt_disk
:import
s and local variables.