Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roles: hosted_engine_setup: Replace xml community module #438

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

arachmani
Copy link
Member

We need to replace community modules since they are not included in
ansible >= 2.11

Bug-Url: https://bugzilla.redhat.com/2022620
Signed-off-by: Asaf Rachmani arachman@redhat.com

We need to replace community modules since they are not included in
ansible >= 2.11

Bug-Url: https://bugzilla.redhat.com/2022620
Signed-off-by: Asaf Rachmani <arachman@redhat.com>
@arachmani arachmani requested a review from mnecas as a code owner March 3, 2022 14:54
Signed-off-by: Asaf Rachmani <arachman@redhat.com>
Signed-off-by: Asaf Rachmani <arachman@redhat.com>
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mnecas mnecas merged commit 2dc3fb1 into oVirt:master Mar 4, 2022
mnecas added a commit to mnecas/ovirt-ansible-collection that referenced this pull request Jun 13, 2022
* roles: hosted_engine_setup: Replace xml community module

We need to replace community modules since they are not included in
ansible >= 2.11

Bug-Url: https://bugzilla.redhat.com/2022620
Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* Add changelog

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

* Use lookup

Signed-off-by: Asaf Rachmani <arachman@redhat.com>

Co-authored-by: Martin Nečas <necas.marty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants