roles: cluster_upgrade: Add progress tracking/reporting #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since cluster upgrade is a very long running process, adding progress tracking allows users and admins to easily track status. Progress tracking is done by posting well formatted events. Bug-Url: https://bugzilla.redhat.com/2040474 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
progress_tracking
branch
from
a7d6147
to
8da7f4d
Compare
mnecas
requested changes
Jan 19, 2022
- It is not used by the cluster upgrade wizard in ovirt's
admin portal.
- The VMs are not stopped anywhere within the role, so this task
doesn't really do anything useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cluster upgrade is a very long running process, adding progress tracking allows users and admins to easily track status. Progress tracking is done by posting well formatted events.
Note:
roles/cluster_upgrade/tasks/upgrade.ymlwas converted to a block. This allows calculating var the tasks for a host upgrade needs without usingset_factstyle global facts. The only annoyance is having to put them at the bottom of the file below all of the tasks.Bug-Url: https://bugzilla.redhat.com/2040474
Signed-off-by: Scott J Dickerson sdickers@redhat.com