Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt_template: modify base template search to return template with lowest version number #370

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

sonneveld
Copy link
Contributor

@sonneveld sonneveld commented Oct 22, 2021

This is an attempt to fix issue #369 .

Basically it seems like ovirt expects the base template to have the lowest version number, not just 1. If the base template is removed, the new base template is chosen but it means this module will fail as it will probably not be version 1.

I haven't contributed to this project before so I'm happy to adjust the PR after comments.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mnecas
Copy link
Member

mnecas commented Oct 22, 2021

ci test please

@sonneveld
Copy link
Contributor Author

ci test please

@mwperina
Copy link
Member

ci add to whitelist

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

@sonneveld
Copy link
Contributor Author

Please add a changelog.

Added a changelog. It looked like the next version will be 1.7.0 so I went with that.

@mnecas
Copy link
Member

mnecas commented Oct 25, 2021

Yeah, my bad did not say how to create the changelog, need to add it to docs.
Fixed it and after CI, will merge, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants