-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovirt_template: modify base template search to return template with lowest version number #370
Conversation
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
…owest version number
c555061
to
5391ce4
Compare
ci test please |
ci test please |
ci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog.
Added a changelog. It looked like the next version will be 1.7.0 so I went with that. |
Yeah, my bad did not say how to create the changelog, need to add it to docs. |
This is an attempt to fix issue #369 .
Basically it seems like ovirt expects the base template to have the lowest version number, not just 1. If the base template is removed, the new base template is chosen but it means this module will fail as it will probably not be version 1.
I haven't contributed to this project before so I'm happy to adjust the PR after comments.