Fix building with LibreSSL #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit c5dce75 introduces a build failure on systems using LibreSSL. LibreSSL, a fork of OpenSSL, aims to modernize the codebase, enhance security, and follow best development practices. The build failure is due to the replacement of `OPENSSL_FULL_VERSION_STR` with `LIBRESSL_VERSION_TEXT`. The latter requires some string manipulation since it is defined as "LibreSSL major.minor.patch".
dnzbk
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The commit c5dce75 introduces a build failure on systems using LibreSSL. LibreSSL, a fork of OpenSSL, aims to modernize the codebase, enhance security, and follow best development practices. The build failure is due to the replacement of
OPENSSL_FULL_VERSION_STRwithLIBRESSL_VERSION_TEXT. The latter requires some string manipulation since it is defined as "LibreSSL major.minor.patch".Lib changes
No changes.
Testing
Build- and run-tested on OpenBSD current. Build-tested on FreeBSD 14.0.