Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #20
This completely overhauls how we handle the class type. Instead of mangling the class to be 'Promisey', we instead require that the original class operates in promises. This is needed because the following class will need code changes as the callback will instead return a
Promise<number>
not anumber
Also by doing this, we can very clearly whitelist what datatypes are allowed to be used, and using anything else will result in type errors.
Additionally, support for property getters/setters has been removed, as they do not translate properly, and end up with the setters wanting to be given a promise, and you cant await the set so could become a floating promise.
This does make it a very breaking change, as any class not specifically designed for this will not work.
TODO
EventEmitter2
in house.ts and move it to be a core type for library consumers to use