This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
workaround for crashing clear-double-boot
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastboot includes some initial DOM parsing to clear server-rendered content (not entirely unlike our
django-for-emberaddon). The problem is that there are some assumptions about the DOM tree that can cause the app to crash if things are not structured 👌just so👌.This patch includes a work around to the issue in
ember-cli-fastboot.I've opened a pr at ember-fastboot/ember-cli-fastboot#699 to fix this issue. Hopefully they will accept it and we won't need this bit of code.
ticket